Core: Add comment property to ViewProperties

apache · Nov 29, 2023 · 5f86df1 · 5f86df1
1 parent d247b20
commit 5f86df1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/core/src/main/java/org/apache/iceberg/view/ViewProperties.java b/core/src/main/java/org/apache/iceberg/view/ViewProperties.java
@@ -25,6 +25,7 @@ public class ViewProperties {
 
   public static final String METADATA_COMPRESSION = "write.metadata.compression-codec";
   public static final String METADATA_COMPRESSION_DEFAULT = "gzip";
+  public static final String COMMENT = "comment";
 
   private ViewProperties() {}
 }
diff --git a/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java b/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java
@@ -107,7 +107,8 @@ public void readAndWriteValidViewMetadata() throws Exception {
             .addVersion(version1)
             .addVersion(version2)
             .setLocation("s3://bucket/test/location")
-            .setProperties(ImmutableMap.of("some-key", "some-value"))
+            .setProperties(
+                ImmutableMap.of("some-key", "some-value", ViewProperties.COMMENT, "some-comment"))
             .setCurrentVersionId(2)
             .upgradeFormatVersion(1)
             .build();
@@ -218,7 +219,9 @@ public void viewMetadataWithMetadataLocation() throws Exception {
                     .addVersion(version1)
                     .addVersion(version2)
                     .setLocation("s3://bucket/test/location")
-                    .setProperties(ImmutableMap.of("some-key", "some-value"))
+                    .setProperties(
+                        ImmutableMap.of(
+                            "some-key", "some-value", ViewProperties.COMMENT, "some-comment"))
                     .setCurrentVersionId(2)
                     .upgradeFormatVersion(1)
                     .build())

diff --git a/core/src/test/resources/org/apache/iceberg/view/ValidViewMetadata.json b/core/src/test/resources/org/apache/iceberg/view/ValidViewMetadata.json
@@ -2,7 +2,7 @@
   "view-uuid": "fa6506c3-7681-40c8-86dc-e36561f83385",
   "format-version": 1,
   "location": "s3://bucket/test/location",
-  "properties": {"some-key": "some-value"},
+  "properties": {"some-key": "some-value", "comment":  "some-comment"},
   "current-schema-id": 0,
   "schemas": [
     {