Skip to content

Commit

Permalink
fix style
Browse files Browse the repository at this point in the history
  • Loading branch information
yyanyy committed Nov 5, 2020
1 parent 3c78091 commit 7cfe754
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@

/**
* Iceberg internally tracked field level metrics, used by Parquet writer only.
* Parquet keeps track of most metrics in its footer, and only NaN counter is actually tracked by writers. This
* wrapper ensures that metrics not being updated by Parquet writers will not be incorrectly used, by throwing
* <p>
* Parquet keeps track of most metrics in its footer, and only NaN counter is actually tracked by writers.
* This wrapper ensures that metrics not being updated by Parquet writers will not be incorrectly used, by throwing
* exceptions when they are accessed.
*/
public class ParquetFieldMetrics extends FieldMetrics {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ public static <K, V> MapWriter<K, V> maps(int dl, int rl,
return new MapWriter<>(dl, rl, keyWriter, valueWriter);
}

@SuppressWarnings("checkstyle:VisibilityModifier")
public abstract static class PrimitiveWriter<T> implements ParquetValueWriter<T> {
@SuppressWarnings("checkstyle:VisibilityModifier")
protected final ColumnWriter<T> column;
private final List<TripleWriter<?>> children;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,10 @@ public static List<DataFile> listPartition(Map<String, String> partition, String

/**
* Returns the data files in a partition by listing the partition location.
*
* <p>
* For Parquet and ORC partitions, this will read metrics from the file footer. For Avro partitions,
* metrics are set to null.
*
* <p>
* Note: certain metrics, like NaN counts, that are only supported by iceberg file writers but not file footers, will
* not be populated.
*
Expand Down

0 comments on commit 7cfe754

Please sign in to comment.