Review

apache · Sep 14, 2023 · e3b188a · e3b188a
1 parent 18afb65
commit e3b188a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
@@ -57,12 +57,12 @@ public VectorHolder(
     this.icebergField = icebergField;
   }
 
-  // Only used for returning dummy holder
+  /** A constructor used for dummy holders. */
   private VectorHolder() {
     this(null);
   }
 
-  // Only used for creating constant holders for fields
+  /** A constructor used for typed constant holders. */
   private VectorHolder(Types.NestedField field) {
     columnDescriptor = null;
     vector = null;
@@ -118,6 +118,8 @@ public static <T> VectorHolder constantHolder(
     return new ConstantVectorHolder<>(icebergField, numRows, constantValue);
   }
 
+  /** @deprecated since 1.4.0, will be removed in 1.5.0; use typed constant holders instead. */
+  @Deprecated
   public static <T> VectorHolder constantHolder(int numRows, T constantValue) {
     return new ConstantVectorHolder<>(numRows, constantValue);
   }
@@ -127,7 +129,7 @@ public static VectorHolder deletedVectorHolder(int numRows) {
   }
 
   public static VectorHolder dummyHolder(int numRows) {
-    return new ConstantVectorHolder(numRows);
+    return new ConstantVectorHolder<>(numRows);
   }
 
   public boolean isDummy() {
@@ -147,6 +149,8 @@ public ConstantVectorHolder(int numRows) {
       this.constantValue = null;
     }
 
+    /** @deprecated since 1.4.0, will be removed in 1.5.0; use typed constant holders instead. */
+    @Deprecated
     public ConstantVectorHolder(int numRows, T constantValue) {
       this.numRows = numRows;
       this.constantValue = constantValue;

diff --git a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
@@ -571,7 +571,7 @@ public void close() {
   public static class ConstantVectorReader<T> extends VectorizedArrowReader {
     private final T value;
 
-    /** @deprecated since 1.4.0, will be removed in 1.5.0. */
+    /** @deprecated since 1.4.0, will be removed in 1.5.0; use typed constant readers. */
     @Deprecated
     public ConstantVectorReader(T value) {
       this.value = value;