Flink: Backport PR #10526 to v1.18 and v1.20 #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhongqishang: |
zhongqishang
commented
Aug 27, 2024
| @@ -242,21 +246,21 @@ public void testOrderedEventsBetweenCheckpoints() throws Exception { | |||
| RowData row1 = SimpleDataUtil.createRowData(1, "hello"); | |||
| DataFile dataFile1 = writeDataFile("data-1", ImmutableList.of(row1)); | |||
|
|
|||
| harness.processElement(of(dataFile1), ++timestamp); | |||
| long firstCheckpointId = 1; | |||
| harness.processElement(of(firstCheckpointId, dataFile1), ++timestamp); | |||
There was a problem hiding this comment.
@pvary When apply V1.20 patch, a misalignment occurred.
But I don't know what caused it, so I fixed it manually.
There was a problem hiding this comment.
I think this is related to @rodmeneses's last commit.
Could you please check @rodmeneses?
Thanks,
Peter
There was a problem hiding this comment.
e6f8ab9#diff-4f79d5342dad9de47d561297e1af60aac21a498f22144ad378dc762affdbfa27L142-L143
Yes, thanks for your reminder.
It should be the modification of TestIcebergFilesCommitter.java that caused the inconsistent line numbers.
|
I via the follow cmd to check the diff There is no difference between 1.19 and 1.20. |
pvary
approved these changes
Aug 30, 2024
|
Merged to main. Thanks for the backport @zhongqishang! |
jenbaldwin
pushed a commit
to Teradata/iceberg
that referenced
this pull request
Sep 17, 2024
* main: (208 commits) Docs: Fix Flink 1.20 support versions (apache#11065) Flink: Fix compile warning (apache#11072) Docs: Initial committer guidelines and requirements for merging (apache#10780) Core: Refactor ZOrderByteUtils (apache#10624) API: implement types timestamp_ns and timestamptz_ns (apache#9008) Build: Bump com.google.errorprone:error_prone_annotations (apache#11055) Build: Bump mkdocs-material from 9.5.33 to 9.5.34 (apache#11062) Flink: Backport PR apache#10526 to v1.18 and v1.20 (apache#11018) Kafka Connect: Disable publish tasks in runtime project (apache#11032) Flink: add unit tests for range distribution on bucket partition column (apache#11033) Spark 3.5: Use FileGenerationUtil in PlanningBenchmark (apache#11027) Core: Add benchmark for appending files (apache#11029) Build: Ignore benchmark output folders across all modules (apache#11030) Spec: Add RemovePartitionSpecsUpdate REST update type (apache#10846) Docs: bump latest version to 1.6.1 (apache#11036) OpenAPI, Build: Apply spotless to testFixtures source code (apache#11024) Core: Generate realistic bounds in benchmarks (apache#11022) Add REST Compatibility Kit (apache#10908) Flink: backport PR apache#10832 of inferring parallelism in FLIP-27 source (apache#11009) Docs: Add Druid docs url to sidebar (apache#10997) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #10526