Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: warn parallelism > 1 doesn't work for migration procedures #11417

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Docs: warn parallelism > 1 doesn't work for migration procedures #11417

merged 4 commits into from
Oct 31, 2024

Conversation

manuzhang
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the docs label Oct 29, 2024
@manuzhang manuzhang changed the title Docs: warn doesn't work for migration procedures Docs: warn parallelism > 1 doesn't work for migration procedures Oct 29, 2024
jbonofre
jbonofre approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable to me to warn the users waiting the actual fix.

@manuzhang manuzhang mentioned this pull request Oct 29, 2024
Open
Fokko
Fokko reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fair to fix this down the line. One small nit on the wording, I try to avoid we.

docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
docs/docs/spark-procedures.md Outdated Show resolved Hide resolved
manuzhang and others added 3 commits October 29, 2024 19:03
@manuzhang @Fokko
Update spark-procedures.md
23cc2e3 
Co-authored-by: Fokko Driesprong <[email protected]>
@manuzhang @Fokko
Update spark-procedures.md
e46a846 
Co-authored-by: Fokko Driesprong <[email protected]>
@manuzhang @Fokko
Update spark-procedures.md
3fd70d0 
Co-authored-by: Fokko Driesprong <[email protected]>
@RussellSpitzer RussellSpitzer merged commit ea61ee4 into apache:main Oct 31, 2024
2 checks passed
@RussellSpitzer
Copy link
Member

RussellSpitzer commented Oct 31, 2024 •
edited
Loading

Thanks @manuzhang We'll figure out that fix before the next release I promise. Thanks @Fokko and @jbonofre for review

RussellSpitzer pushed a commit to RussellSpitzer/iceberg that referenced this pull request Nov 4, 2024
@manuzhang @RussellSpitzer
Docs: warn parallelism > 1 doesn't work for migration procedures (a…
105fa7b 
…pache#11417)
RussellSpitzer pushed a commit that referenced this pull request Nov 4, 2024
@manuzhang @RussellSpitzer
Docs: warn parallelism > 1 doesn't work for migration procedures (#…
5f7c992 
…11417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@jbonofre jbonofre jbonofre approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuzhang @RussellSpitzer @jbonofre @Fokko