Spark 3.5: Adapt DeleteFileIndexBenchmark for DVs #11529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts our
DeleteFileIndexBenchmark
for DVs.The reason partition-scoped deletes are fastest is because the benchmark sets up a table with a small number of deep partitions (50K data files per partition) and only 100 delete files per partition. Therefore, the number of delete files differs dramatically. We should probably make this benchmark more representative in the future. DVs are faster than file-scoped deletes because they rely on
referencedDataFile
instead of reconstructing that value from bounds. I'd say the planning performance is acceptable for 2.5M DVs, but we may want to further optimize it.This work is part of #11122.