Nessie: Replace CommitStateUnknownException with CommitFailedException #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
nessie-replace-commitstateunknown-ex
branch
from
26c7355
to
e2dee94
Compare
| @@ -274,12 +273,9 @@ public void renameTable(TableIdentifier from, TableIdentifier to) { | |||
| // to catch all kinds of network errors (e.g. connection reset). Network code implementation | |||
| // details and all kinds of network devices can induce unexpected behavior. So better be | |||
| // safe than sorry. | |||
| throw new CommitStateUnknownException(ex); | |||
| throw new CommitFailedException(ex, "Cannot rename table '%s' to '%s': " + | |||
There was a problem hiding this comment.
I'm not sure this is right, I think this was originally added because some of the exceptions here do happen when the commit succeeded on the server but it failed to propagate the ack back to the client. At least that's what I was told when this got added way back when. If things have changed let me know.
There was a problem hiding this comment.
seems you have more historical background than I do and in fact you are totally right, because that's exactly the case that's happening here. Closing the PR then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #4491