Core: Fix drop table without purge for REST session catalog #6511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
As per documentation of
SessionCataog.dropTable
saysBut the
RESTSessionCatalog#dropTable
API purges the table even if we are not settingpurgeRequested
totrue
.The issue is happening because, While handling
DROP_TABLE
request inRESTCatalogAdapter
, the call goes toCatalogHandlers.dropTable(Catalog catalog, TableIdentifier ident)
whenpurgeRequested
is not set and internally callscatalog.dropTable(ident)
that always drops the table with purge.iceberg/core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java
Lines 225 to 230 in cd21f68
Fix:
Fix
CatalogHandlers.dropTable(Catalog catalog, TableIdentifier ident)
API that drops the table without purge.This PR is to fix the
dropTable
API for REST Session Catalog for dropping table without purging.