Spark 3.1 3.2: Fix always true/false condition in rewrite_data_files #7760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szehon-ho
reviewed
Jun 13, 2023
| val optimizedLogicalPlan = session.sessionState.executePlan(logicalPlan).optimizedPlan | ||
| val tableAttrs = session.table(tableName).queryExecution.analyzed.output | ||
| val unresolvedExpression = session.sessionState.sqlParser.parseExpression(where) | ||
| val filter = Filter(unresolvedExpression, DummyRelation(tableAttrs)) |
There was a problem hiding this comment.
I'm not too familiar, but the removal of select 42 is part of #6524, and I'm not confident if we can put that change here as well.
There was a problem hiding this comment.
it seems that "select 42 from table where" is used only to form a complete sql sentence together with the where condtion. now we can evaluate the where condtion directly without this "select" sql sentence.
|
Please rebase. spark-3.1 module is removed from master code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport the fix in the PR (#6760) to Spark 3.1 and 3.2 versions.