Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Make Glue catalog configurable #7781

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

tilman151
Copy link
Contributor

This PR concerns issue #7777.

It makes it possible to pass AWS credentials directly through the Python API, when loading a Glue catalog. Additionally, the profile_name of the desired AWS profile can be selected. Currently, the default profile is used.

@tilman151 tilman151 marked this pull request as ready for review June 6, 2023 13:04
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tilman151 this looks great, thanks for creating this PR! Could you remove the unrelated changes, then this is good to go!

python/README.md Outdated Show resolved Hide resolved
python/mkdocs/docs/contributing.md Outdated Show resolved Hide resolved
python/mkdocs/docs/feature-support.md Outdated Show resolved Hide resolved
@Fokko Fokko added this to the PyIceberg 0.4.0 release milestone Jun 7, 2023
@tilman151 tilman151 force-pushed the feat/make-boto-session-configurable branch from c748236 to 4ffccf0 Compare June 9, 2023 06:45
@tilman151 tilman151 force-pushed the feat/make-boto-session-configurable branch from 4ffccf0 to 461d4a1 Compare June 9, 2023 06:46
@tilman151 tilman151 force-pushed the feat/make-boto-session-configurable branch from 461d4a1 to 38a34c3 Compare June 9, 2023 06:48
@tilman151
Copy link
Contributor Author

@Fokko done. These changes were introduced by running the pre-commit linting. I didn't notice while commiting.

@Fokko Fokko changed the title Make boto3 session for glue catalog configurable Python: Make Glue catalog configurable Jun 13, 2023
@Fokko
Copy link
Contributor

Fokko commented Jun 13, 2023

@tilman151 Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants