Spark 3.4: disallow update identifier fields through alter table set tblproperties #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
commented
Aug 14, 2023
| @@ -55,7 +59,7 @@ public void removeTable() { | |||
|
|
|||
| @Test | |||
| public void testAddColumnNotNull() { | |||
| Assertions.assertThatThrownBy(() -> sql("ALTER TABLE %s ADD COLUMN c3 INT NOT NULL", tableName)) | |||
| assertThatThrownBy(() -> sql("ALTER TABLE %s ADD COLUMN c3 INT NOT NULL", tableName)) | |||
There was a problem hiding this comment.
Since we are migrating to AssertJ, I changed some of the assertion code to the AssertJ ones.
|
@liuml07 and @jackye1995 would you mind to review this since you guys changed the related parts of code? |
aokolnychyi
approved these changes
Aug 15, 2023
|
Thanks, @advancedxy! |
|
Thanks @aokolnychyi for reviewing and merging 🎆 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
sort-order, I noticed it's still allowed to update theidentifier-fieldsproperty through alter table when browsing related code. Although bothsort-orderandidentifier-fieldshave been overwrote inorg.apache.iceberg.spark.source.SparkTable#propertiesmethod, it wouldn't cause any correctness problems. I think it's better to throw an exception foridentifier-fieldsas well.