Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: FixupTypes copied doc info. #8416

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

baiyangtx
Copy link
Contributor

Closes #8415

@github-actions github-actions bot added the core label Aug 29, 2023
@Fokko
Copy link
Contributor

Fokko commented Aug 29, 2023

Oof, that's a great catch @baiyangtx. Can you run ./gradlew :iceberg-core:spotlessApply?

@baiyangtx
Copy link
Contributor Author

Ok, I will try that.

@baiyangtx
Copy link
Contributor Author

Hi, All checks have passed, can this PR be merged?

Thanks. @Fokko

@Fokko
Copy link
Contributor

Fokko commented Aug 31, 2023

@baiyangtx Thanks for working on this, I'll merge this so it is part of 1.4.0

@Fokko Fokko merged commit f688363 into apache:master Aug 31, 2023
41 checks passed
@baiyangtx baiyangtx deleted the fixupTypes_lost_doc_info branch September 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants