Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master branch to main #8722

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Rename master branch to main #8722

merged 1 commit into from
Oct 12, 2023

Conversation

jbonofre
Copy link
Member

@jbonofre jbonofre commented Oct 5, 2023

This PR rename resources using master to main. This PR should be merged only when the renaming has been done by Apache INRA.

README.md Show resolved Hide resolved
docs/flink-writes.md Outdated Show resolved Hide resolved
**/build/testlogs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unrelated modification?

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

@rdblue
Copy link
Contributor

rdblue commented Oct 5, 2023

@jbonofre, how will this affect existing PRs? Do all of them need to be reopened against main instead of master?

@jbonofre
Copy link
Member Author

jbonofre commented Oct 5, 2023

@rdblue no impact on the existing PRs: they will be "attached" to main instead of master. The only impact is for the remotes for our users.

Copy link
Contributor

@rdblue rdblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is good to go when the rename has happened.

@jbonofre
Copy link
Member Author

jbonofre commented Oct 6, 2023

Thanks, I do a cleanup on this PR and I create a INFRA ticket to actually rename.

@jbonofre
Copy link
Member Author

@ajantha-bhat I did a rebase to remove the python related resources, and the "formatting" should be OK now.

@jbonofre
Copy link
Member Author

As soon as @ajantha-bhat vote +1 on this PR, I will create the ticket at Apache INFRA to trigger the rename.

@ajantha-bhat
Copy link
Member

@jbonofre: LGTM. Thanks for fixing the formatting too.

@jbonofre
Copy link
Member Author

master branch has been renamed to main.

@Fokko @nastra if you can merge this PR when you have time, it would be great. Thanks !

@Fokko Fokko merged commit 6530a3e into apache:main Oct 12, 2023
46 checks passed
@Fokko
Copy link
Contributor

Fokko commented Oct 12, 2023

Thanks @jbonofre for taking the lead on this!

@jbonofre jbonofre deleted the MOVE2MAIN branch January 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants