Core: Add table session cache #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Oct 28, 2023
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Oct 28, 2023
|
|
||
| return session != null ? session : parent; | ||
| } | ||
|
|
||
| private String cacheKeyFromConf(Map<String, String> tableConf) { | ||
| // this logic needs to be in-line with newSession(credentials, properties, parent) |
There was a problem hiding this comment.
Because of this, I think it makes more sense to rely on the same code. What about refactoring to extract a pair, which is the key that was found and the value? Then we can use that pair for caching and pass it into newSession.
The purpose of caching auth session for tables is mainly so that we can stop refreshing the session when it isn't used anymore
nastra
force-pushed
the
table-session-cache
branch
from
b210c68
to
d955e23
Compare
amogh-jahagirdar
approved these changes
Nov 2, 2023
rdblue
approved these changes
Dec 10, 2023
This was referenced Dec 11, 2023
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
The purpose of caching auth session for tables is mainly so that we can stop refreshing the session when it isn't used anymore
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
The purpose of caching auth session for tables is mainly so that we can stop refreshing the session when it isn't used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of caching auth session for tables is mainly so that we can stop refreshing the session when it isn't used anymore