AWS: Support setting description for Glue table #9530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Thanks for the change @lkokhreidze !
can you please also update the integ test for TestGlueCatalogTable#testCreateTable to assert the description being set ?
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
Show resolved
Hide resolved
|
Thanks for the review @singhpk234! I've addressed your comments. |
singhpk234
approved these changes
Jan 24, 2024
amogh-jahagirdar
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
This looks good to me, thanks @lkokhreidze ! Thanks @singhpk234 for the review! I'll merge after the CI completes.
|
@lkokhreidze Could you run spotless |
|
Thanks @amogh-jahagirdar and apologies, should have done it beforehand. Pushed the changes |
|
No problem at all @lkokhreidze thanks for the contribution, thanks @singhpk234 for the review! |
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9462