Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Update S3FileIO test to run when CLIENT_FACTORY is not set #9541

Merged
merged 2 commits into from
Jan 25, 2024
Merged

AWS: Update S3FileIO test to run when CLIENT_FACTORY is not set #9541

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a873d3
Update S3FileIO test to run when CLIENT_FACTORY is not set
Jan 21, 2024
bf71284
Minor: revert file name
Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,12 @@ public void testS3FileIOWithS3FileIOAwsClientFactoryImpl() throws Exception {
}

@Test
public void testS3FileIOWithDefaultAwsClientFactoryImpl() throws Exception {
public void testS3FileIOWithAwsClientFactoryImpl() throws Exception {
alok123t marked this conversation as resolved.
Show resolved Hide resolved
s3.putObject(
PutObjectRequest.builder().bucket(bucketName).key(objectKey).build(),
RequestBody.fromBytes(contentBytes));
S3FileIO s3FileIO = new S3FileIO();
Map<String, String> properties = Maps.newHashMap();
properties.put(
S3FileIOProperties.CLIENT_FACTORY,
"org.apache.iceberg.aws.s3.DefaultS3FileIOAwsClientFactory");
s3FileIO.initialize(properties);
s3FileIO.initialize(Maps.newHashMap());
validateRead(s3FileIO);
}

Expand Down