-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pagination To List Apis #9782
Conversation
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/responses/ListTablesResponse.java
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/responses/ListTablesResponse.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/responses/ListNamespacesResponse.java
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/responses/ListNamespacesResponse.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
0d43bd0
to
383c2d9
Compare
@jackye1995 @rdblue @danielcweeks @nastra If you can take a look at the revision for this whenever you guys get a chance would be appreciated. |
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java
Outdated
Show resolved
Hide resolved
I just want to add a few high-level comments here:
As a follow up to #2, it seems there may be a chase were some servers require pagination, so they will probably need to return a 400 BadRequest if a client is asking for all values in a request and the server requires they support pagination. |
@danielcweeks @nastra @rdblue @jackye1995 @sachet
|
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/rest/responses/TestListTablesResponse.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few minor comments, but this LGTM now. Thanks @rahil-c. I'll wait a bit with merging to also give @danielcweeks a chance to take another look
Thanks @nastra for the help I appreciate it, will wait on @danielcweeks review. |
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
@danielcweeks @nastra Have made recent revisions, hoping we can land this if no other concerns and if CI run is green. |
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java
Outdated
Show resolved
Hide resolved
Approved, pending checks. There's one that failed, but may have been a transient failure. |
@danielcweeks yea I think it is transient, since every time I go to check this link it still keeps running. |
@danielcweeks Seems to be green now |
Thanks for working on this @rahil-c |
Thanks @nastra and @danielcweeks for the help on this! |
Implemented pagination in list apis based on the spec: #9660
@jackye1995 @nastra @danielcweeks @geruh
Testing