Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue template and docs for iceberg proposals #9932

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Add issue template and docs for iceberg proposals #9932

merged 7 commits into from
Mar 20, 2024

Conversation

danielcweeks
Copy link
Contributor

This PR adds an issue template for Iceberg improvement proposals and adds docs to the site to cover the proposal process.

@danielcweeks
Copy link
Contributor Author

@jbonofre I'm not sure why I can't add you as a reviewer.

@ajantha-bhat
Copy link
Member

ajantha-bhat commented Mar 12, 2024 •
edited
Loading

@jbonofre I'm not sure why I can't add you as a reviewer.

What I observed is only collaborators, committers can be added as reviewer.
https://github.com/apache/iceberg/blob/main/.asf.yaml

So, I manually CC them in the PR for review if required.

liurenjie1024
liurenjie1024 reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just added some minor nits.

.github/ISSUE_TEMPLATE/iceberg_proposal.yml Show resolved Hide resolved
site/docs/contribute.md Outdated Show resolved Hide resolved
site/docs/contribute.md Outdated Show resolved Hide resolved
@jbonofre
Copy link
Member

@danielcweeks That's because my user is not in the collaborators list in .asf.yml. Let me check with asfinfra if we can have more than 10 entries in collaborators.

jbonofre
jbonofre reviewed Mar 14, 2024
View reviewed changes
site/docs/contribute.md Outdated Show resolved Hide resolved
Fokko
Fokko approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

RussellSpitzer
RussellSpitzer approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielcweeks danielcweeks merged commit 7151401 into apache:main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonofre jbonofre jbonofre approved these changes

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@stevenzwu stevenzwu stevenzwu approved these changes

@Fokko Fokko Fokko approved these changes

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@nastra nastra nastra approved these changes

@rdblue rdblue rdblue approved these changes

@bitsondatadev bitsondatadev Awaiting requested review from bitsondatadev

Assignees
No one assigned
Labels
docs INFRA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danielcweeks @ajantha-bhat @jbonofre @rdblue @nastra @RussellSpitzer @Fokko @stevenzwu @liurenjie1024