Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASF related links #47

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Add ASF related links #47

merged 1 commit into from
Mar 9, 2024

Conversation

CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Mar 7, 2024

image

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Mar 7, 2024

Oddly, the font is displayed in black... Hi, @bchapuis Could you take a look:)

@bchapuis
Copy link
Member

bchapuis commented Mar 7, 2024

@CalvinKirs Thanks a lot for adding these missing links. I tested locally and it looks good to me. Do not hesitate to go ahead and merge the PR.

I'm not sure to understand the issue with the font displayed in black. Is there something we should handle separatly?

@CalvinKirs
Copy link
Member Author

@CalvinKirs Thanks a lot for adding these missing links. I tested locally and it looks good to me. Do not hesitate to go ahead and merge the PR.↳

I'm not sure to understand the issue with the font displayed in black. Is there something we should handle separatly?↳

I'm not sure why my newly added tabs are displayed in bold black...

@bchapuis
Copy link
Member

bchapuis commented Mar 7, 2024

Ah, I see. The menu is usually displayed in bold when you navigate to the section or one of its subpages. I havn't been able to reproduce this issue for the "Apache" section as it only contains links.

@bchapuis bchapuis merged commit 2c8eb3c into apache:main Mar 9, 2024
2 checks passed
@CalvinKirs CalvinKirs deleted the asf branch March 11, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants