Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-1217][VL] UT: Enable UT when partitioned column is decimal type #1230

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Mar 29, 2023

What changes were proposed in this pull request?

Enable Resolve type conflicts - decimals, dates and timestamps in partition column.
oap-project/velox#167
#1217

How was this patch tested?

Testing on CI.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@rui-mo rui-mo changed the title Enable UT when partitioned column is decimal type [VL] Enable UT when partitioned column is decimal type Mar 29, 2023
@zhouyuan zhouyuan added the velox backend works for Velox backend label Mar 29, 2023
@rui-mo rui-mo force-pushed the fix_part branch 3 times, most recently from b84d7fe to 705505c Compare April 3, 2023 02:20
@kyligence-git
Copy link
Contributor

Can one of the admins verify this patch?

@rui-mo rui-mo changed the title [VL] Enable UT when partitioned column is decimal type [GLUTEN-1217][VL] UT: Enable UT when partitioned column is decimal type Apr 3, 2023
@rui-mo rui-mo merged commit c2263a3 into apache:main Apr 3, 2023
@rui-mo rui-mo deleted the fix_part branch October 25, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
velox backend works for Velox backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants