Update DMN related documentation on main-kogito #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PRs brings DMN docs changes introduced on main in 1H2023 - https://github.com/kiegroup/kie-docs/pull/4464 (cherry-pick completely the same content) - https://github.com/kiegroup/kie-docs/pull/4512 (cherry-pick was not possible, we remove 'Business Modeler hub' term in this PR)
jomarko
force-pushed
the
dmn-modeler-cherry-picks
branch
from
5030b56
to
c601567
Compare
jomarko
requested review from
kaldesai and
hmanwani-rh
and removed request for
hmanwani-rh
kaldesai
reviewed
Aug 29, 2023
doc-content/kogito-docs/src/main/asciidoc/dmn/chap-kogito-using-dmn-models.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Aug 29, 2023
| @@ -583,6 +583,8 @@ The following decision table hit policies are supported in DMN: | |||
| ** *Collect Min (C<):* Outputs the minimum value among the matches. The resulting values must be comparable, such as numbers, dates, or text (lexicographic order). | |||
| ** *Collect Max (C>):* Outputs the maximum value among the matches. The resulting values must be comparable, such as numbers, dates or text (lexicographic order). | |||
| ** *Collect Count (C#):* Outputs the number of matching rules. | |||
| ** *Rule Order (R):* Collects output from multiple rules into list ordered according to rules order. It is very similar as 'Collect' without any aggregation function, but with explicit consistent ordering in the final list as defined in the table. | |||
There was a problem hiding this comment.
Suggested change
| ** *Rule Order (R):* Collects output from multiple rules into list ordered according to rules order. It is very similar as 'Collect' without any aggregation function, but with explicit consistent ordering in the final list as defined in the table. | |
| ** *Rule Order (R):* Collects output from multiple rules into a list ordered according to rules order. It is very similar to 'Collect' without any aggregation function, but with explicit consistent ordering in the final list as defined in the table. |
kaldesai
reviewed
Aug 29, 2023
| @@ -583,6 +583,8 @@ The following decision table hit policies are supported in DMN: | |||
| ** *Collect Min (C<):* Outputs the minimum value among the matches. The resulting values must be comparable, such as numbers, dates, or text (lexicographic order). | |||
| ** *Collect Max (C>):* Outputs the maximum value among the matches. The resulting values must be comparable, such as numbers, dates or text (lexicographic order). | |||
| ** *Collect Count (C#):* Outputs the number of matching rules. | |||
| ** *Rule Order (R):* Collects output from multiple rules into list ordered according to rules order. It is very similar as 'Collect' without any aggregation function, but with explicit consistent ordering in the final list as defined in the table. | |||
There was a problem hiding this comment.
Suggested change
| ** *Rule Order (R):* Collects output from multiple rules into list ordered according to rules order. It is very similar as 'Collect' without any aggregation function, but with explicit consistent ordering in the final list as defined in the table. | |
| ** *Rule Order (R):* Collects output from multiple rules into a list ordered according to rules order. It is very similar to 'Collect' without any aggregation function, but with explicit consistent ordering in the final list as defined in the table. |
kaldesai
reviewed
Aug 29, 2023
doc-content/kogito-docs/src/main/asciidoc/dmn/chap-kogito-using-dmn-models.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Aug 29, 2023
doc-content/kogito-docs/src/main/asciidoc/creating-running/chap-kogito-creating-running.adoc
Outdated
Show resolved
Hide resolved
…p-kogito-creating-running.adoc Co-authored-by: Kalyani Desai <[email protected]>
…g-dmn-models.adoc Co-authored-by: Kalyani Desai <[email protected]>
…g-dmn-models.adoc Co-authored-by: Kalyani Desai <[email protected]>
|
@kaldesai thank you, suggestions committed and pushed. |
|
@kiegroup/gatekeepers please merge |
|
squashing and merging as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs brings DMN docs changes introduced on main in 1H2023
Thank you for submitting this pull request
JIRA: (please edit the JIRA link if it exists)
link
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.