Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limiter for backup request #778

Closed
levy5307 opened this issue Jul 8, 2021 · 0 comments
Closed

Add rate limiter for backup request #778

levy5307 opened this issue Jul 8, 2021 · 0 comments
Labels
type/enhancement Indicates new feature requests
Milestone

Comments

@levy5307
Copy link
Contributor

levy5307 commented Jul 8, 2021

Feature Request

Previously, we implemented a feature which name is backup request. And we don't add a rate limiter for it. So it will cause jitter if it's qps or throughput is too large.

In the implementation of backup request, it will only accept the first response it receives. Which means if we reject a backup request immediately after server receives it, the response corresponding to the request which sending to primary replica will be ignored. So we can't simply reject the backup request when it is received.

One way to deal with this problem is adding a rate limiter on client side. But there is a problem that we can't easily change the limiting values according to the actual situation.

In my opinion, we should add rate limiter on server side. And we may don't send a response to the backup request that has been limited. In this way, client will not receive a response corresponding to the backup request, and it can wait for the response from primary replica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants