feat: add rename_app interface #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Dec 1, 2022
GehaFearless
force-pushed
the
liguohao_rename
branch
3 times, most recently
from
c1bef77
to
0517fe7
Compare
acelyc111
reviewed
Dec 4, 2022
acelyc111
reviewed
Dec 5, 2022
empiredan
reviewed
Dec 5, 2022
empiredan
reviewed
Dec 8, 2022
GehaFearless
force-pushed
the
liguohao_rename
branch
from
43823a5
to
25eaf5f
Compare
acelyc111
reviewed
Dec 12, 2022
acelyc111
reviewed
Dec 12, 2022
levy5307
reviewed
Dec 14, 2022
| @@ -53,6 +53,15 @@ | |||
| namespace dsn { | |||
| namespace replication { | |||
|
|
|||
| #define VALIDATE_TABLE_NAME(app_name) \ | |||
There was a problem hiding this comment.
inline bool validate_table_name(std::string app_name) {
...
}
I think it's better to implement it by inline func
levy5307
approved these changes
Dec 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #1185
I want add a couple rpc to solve rename app.