fix: Fix the corruption RocksDB instance will be reused bug #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
crash_rdb_crpt
branch
2 times, most recently
from
34a0939
to
ec13620
Compare
acelyc111
force-pushed
the
crash_rdb_crpt
branch
from
44189c0
to
b0588a6
Compare
levy5307
approved these changes
Apr 6, 2023
foreverneverer
approved these changes
Apr 6, 2023
empiredan
approved these changes
Apr 11, 2023
Closed
GehaFearless
pushed a commit
to GehaFearless/incubator-pegasus
that referenced
this pull request
Feb 28, 2024
…apache#1422) 对应社区commit: https://github.com/apache/incubator-pegasus/pull/1422/files 其中，单测 integration_test.cpp 未添加，原因是整个function test的变更过大不便添加，等 最后都合入后再单独补充 apache#1383 This patch deal with the error `kCorruption` returned from storage engine of write requests. After replica server got such an error, it will trash the replica to a trash path `<app_id>.<pid>.pegasus.<timestamp>.err`. Note that the replica server may crash because the corrupted replica has been trashed and closed, it is left to be completed by another patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1383
This patch deal with the error
kCorruptionreturned from storageengine of write requests. After replica server got such an error,
it will trash the replica to a trash path
<app_id>.<pid>.pegasus.<timestamp>.err.Note that the replica server may crash because the corrupted replica
has been trashed and closed, it is left to be completed by another
patches.