refactor: improve the single-responsibility of class fs_manager #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
mv_func_2_fs_mgr2
branch
2 times, most recently
from
f187ca9
to
ae54a7a
Compare
acelyc111
changed the title
acelyc111
force-pushed
the
mv_func_2_fs_mgr2
branch
from
94b929f
to
8610b58
Compare
acelyc111
changed the title
levy5307
reviewed
May 23, 2023
levy5307
reviewed
May 23, 2023
| @@ -67,14 +68,14 @@ const std::string kFolderSuffixBak = ".bak"; | |||
| const std::string kFolderSuffixOri = ".ori"; | |||
| const std::string kFolderSuffixTmp = ".tmp"; | |||
|
|
|||
| error_s disk_remove_useless_dirs(const std::vector<std::string> &data_dirs, | |||
| error_s disk_remove_useless_dirs(const std::vector<std::shared_ptr<dir_node>> &dir_nodes, | |||
There was a problem hiding this comment.
What about using weak_ptr instead of shared_ptr?
There was a problem hiding this comment.
I don't think it's necessary. If supporting to remove dir_node from fs manager, we have to make sure it's safe to access the dir_node in disk_remove_useless_dirs() even if it has been removed, std::shared_ptr is safe in this case.
|
LGT1. (^_^)v |
levy5307
previously approved these changes
May 24, 2023
empiredan
reviewed
May 25, 2023
empiredan
approved these changes
May 25, 2023
levy5307
approved these changes
May 25, 2023
Closed
empiredan
added
the
type/config-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1383
This patch moves some functions to fs_manager which are more reasonable to be
responsibilities of class fs_manager rather than those of class replica_stub.
A new configuration is added:
[replication] + ignore_broken_disk = true