fix: bind prometheus exposer to 0.0.0.0 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Apr 27, 2020
| @@ -106,6 +106,17 @@ copy_file `get_system_lib server aio` ${pack}/bin/`get_system_libname server aio | |||
| copy_file `get_system_lib server zstd` ${pack}/bin/`get_system_libname server zstd` | |||
| copy_file `get_system_lib server lz4` ${pack}/bin/`get_system_libname server lz4` | |||
|
|
|||
| DISTRIB_ID=$(cat /etc/*-release | grep DISTRIB_ID | awk -F'=' '{print $2}') | |||
There was a problem hiding this comment.
what's the meaning of these code?
There was a problem hiding this comment.
Because binary on linux distribution based on Debian Wheezy requires dependencies of icudata, icuuc, icui18n. If I build a binary on Ubuntu18.04, and want to distribute it to other platforms, like linux in docker, I need to include the libraries in my package.
See this: wkhtmltopdf/wkhtmltopdf#2242
levy5307
approved these changes
Apr 27, 2020
hycdong
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The prometheus exposer formerly bound to an external IP address, for example "10.231.52.xxx:9091", and served on the HTTP URL '10.231.52.xxx:9091/metrics'. But it's unable to serve on '0.0.0.0:9091' and '127.0.0.1:9091'. It is therefore inconvenient to set up an onebox environment with prometheus.
This limitation can be resolved by binding to '0.0.0.0:9091' so that '0.0.0.0:9091', '127.0.0.1:9091', '10.231.52.xxx:9091' are all accessible.
Check List
Tests
Related changes