Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start compaction operation in CompactionFilter::Filter #780

Merged
merged 9 commits into from
Jul 20, 2021

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Jul 13, 2021

What problem does this PR solve?

start compaction operation in CompactionFilter::Filter
RFC: https://github.com/apache/incubator-pegasus/blob/master/rfcs/2021-05-27-user-specified-compaction.md

What is changed and how does it work?

Checklist

Tests
  • Manual test (add detailed scripts or steps below)
  1. insert a value into app temp
>>> use temp
OK
>>> set a b c 3000
OK

app_id          : 2
partition_index : 4
decree          : 4
server          : 10.231.57.100:34802
  1. add a compaction operation which delete key with ttl in [1000, 10000]
  2. start manual compact
  3. get the value, and found it was deleted
>>> get a b 
Not found

app_id          : 2
partition_index : 4
server          : 10.231.57.100:34802
>>> 

@levy5307 levy5307 merged commit ea1fdc7 into apache:master Jul 20, 2021
@levy5307 levy5307 deleted the do-filter-compaction branch July 20, 2021 04:07
@hycdong hycdong mentioned this pull request Sep 23, 2021
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants