Skip to content

Commit

Permalink
add dubbo transtation filter test (#204)
Browse files Browse the repository at this point in the history
test: add unit test for dubbo transtation filter
  • Loading branch information
jasondeng1997 authored Aug 14, 2022
1 parent ea5002a commit 02df300
Show file tree
Hide file tree
Showing 2 changed files with 95 additions and 1 deletion.
95 changes: 95 additions & 0 deletions pkg/integration/dubbo/dubbo_transaction_filter_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package dubbo

import (
"context"

"testing"

"dubbo.apache.org/dubbo-go/v3/filter"
"dubbo.apache.org/dubbo-go/v3/protocol"
"github.com/stretchr/testify/assert"
)

// TestGetDubboTransactionFilter unit test for GetDubboTransactionFilter
func TestGetDubboTransactionFilter(t *testing.T) {
tests := []struct {
name string
want filter.Filter
}{
{
name: "TestGetDubboTransactionFilter",
want: GetDubboTransactionFilter(),
},
{
name: "TestGetDubboTransactionFilter1",
want: GetDubboTransactionFilter(),
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
assert.Equal(t, GetDubboTransactionFilter(), tt.want)

})
}
}

// TestGetDubboTransactionFilter unit test for GetDubboTransactionFilter
func TestDubboTransactionFilterOnResponse(t *testing.T) {
type args struct {
ctx context.Context
result protocol.Result
invoker protocol.Invoker
invocation protocol.Invocation
}
tests := []struct {
name string
args args
want protocol.Result
}{
{
name: "Test_dubboTransactionFilter_OnResponse",
args: args{
ctx: context.Background(),
result: nil,
invoker: nil,
invocation: nil,
},
want: nil,
},
{
name: "Test_dubboTransactionFilter_OnResponse1",
args: args{
ctx: context.TODO(),
result: nil,
invoker: nil,
invocation: nil,
},
want: nil,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
du := &dubboTransactionFilter{}
got := du.OnResponse(tt.args.ctx, tt.args.result, tt.args.invoker, tt.args.invocation)
assert.Equal(t, got, tt.want)

})
}
}
1 change: 0 additions & 1 deletion pkg/protocol/codec/global_begin_request_codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func (c *GlobalBeginRequestCodec) Encode(in interface{}) []byte {
func (g *GlobalBeginRequestCodec) Decode(in []byte) interface{} {
data := message.GlobalBeginRequest{}
buf := bytes.NewByteBuffer(in)

data.Timeout = int32(bytes.ReadUInt32(buf))
data.TransactionName = bytes.ReadString16Length(buf)

Expand Down

0 comments on commit 02df300

Please sign in to comment.