-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【待优化】[config] Init conf #193
Conversation
02c41fa
to
b5c5f68
Compare
pkg/config/registry_config_test.go
Outdated
age int | ||
} | ||
|
||
//方法 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete all Chinese characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In coding, I will pay attention to such issues in the future
pls associat a issue |
|
||
import "github.com/seata/seata-go/pkg/common/constant" | ||
|
||
type StoreConfig struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is store config for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way transaction data is stored, eg. src/main/resources/application.example.yml
pkg/config/root_config.go
Outdated
} | ||
|
||
// init registry | ||
registry := rc.RegistryConf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why only init RegistryConf?
StoreConf *StoreConfig `yaml:"store" json:"store" property:"store" hcl:"store"` | ||
RegistryConf *RegistryConfig `yaml:"registry" json:"registry" property:"registry" hcl:"registry"` | ||
MetricsConf *MetricsConfig `yaml:"metrics" json:"metrics" property:"metrics" hcl:"metrics"` | ||
TransportConf *TransportConfig `yaml:"transport" json:"transport" property:"transport" hcl:"transport"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why RootConfig not contains other config, such as gettyConfig, profilesConfig......
) | ||
|
||
// ServerConfig holds supported types by the multiconfig package | ||
type ServerConfig struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't has TC, is this necessary?
please link some issues |
参考PR:#285 |
Reference PR: https://github.com/seta/seta-go/pull/285 |
参考PR:#285 |
Reference PR: https://github.com/seta/seta-go/pull/285 |
init conf