Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【待优化】[config] Init conf #193

Closed
wants to merge 4 commits into from

Conversation

langlaile1221
Copy link

init conf

@langlaile1221 langlaile1221 changed the title init conf [config] Init conf Aug 5, 2022
age int
}

//方法
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all Chinese characters

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In coding, I will pay attention to such issues in the future

@luky116
Copy link
Contributor

luky116 commented Aug 6, 2022

pls associat a issue


import "github.com/seata/seata-go/pkg/common/constant"

type StoreConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is store config for

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way transaction data is stored, eg. src/main/resources/application.example.yml

}

// init registry
registry := rc.RegistryConf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only init RegistryConf?

StoreConf *StoreConfig `yaml:"store" json:"store" property:"store" hcl:"store"`
RegistryConf *RegistryConfig `yaml:"registry" json:"registry" property:"registry" hcl:"registry"`
MetricsConf *MetricsConfig `yaml:"metrics" json:"metrics" property:"metrics" hcl:"metrics"`
TransportConf *TransportConfig `yaml:"transport" json:"transport" property:"transport" hcl:"transport"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why RootConfig not contains other config, such as gettyConfig, profilesConfig......

)

// ServerConfig holds supported types by the multiconfig package
type ServerConfig struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't has TC, is this necessary?

@106umao
Copy link
Contributor

106umao commented Aug 10, 2022

please link some issues

@luky116 luky116 changed the title [config] Init conf 【待优化】[config] Init conf Oct 15, 2022
@luky116
Copy link
Contributor

luky116 commented Oct 30, 2022

参考PR:#285

@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Reference PR: https://github.com/seta/seta-go/pull/285

@luky116 luky116 closed this Oct 30, 2022
@luky116 luky116 reopened this Nov 12, 2022
@luky116
Copy link
Contributor

luky116 commented Nov 30, 2022

参考PR:#285

@luky116 luky116 closed this Nov 30, 2022
@Issues-translate-bot
Copy link

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Reference PR: https://github.com/seta/seta-go/pull/285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants