feat: add xa #467
Merged
feat: add xa #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondeng1997
approved these changes
Mar 11, 2023
|
fix Conflict |
wang1309
reviewed
Mar 11, 2023
pkg/datasource/sql/db.go
Outdated
|
|
||
| func (db *DBResource) init() error { | ||
| db.checkDbVersion() | ||
| return nil |
There was a problem hiding this comment.
如果写死的return nil，那是不是可以不需要error 返回值了
| "database/sql" | ||
| "flag" | ||
| "fmt" | ||
| "github.com/pkg/errors" |
| } | ||
|
|
||
| if !c.xaActive || c.xaBranchXid == nil { | ||
| return fmt.Errorf("should NOT rollback on an inactive session") |
| } | ||
|
|
||
| if !c.xaActive || c.xaBranchXid == nil { | ||
| return fmt.Errorf("should NOT commit on an inactive session") |
pkg/datasource/sql/connector.go
Outdated
| func (c *seataConnector) dbVersion(ctx context.Context, conn driver.Conn) (string, error) { | ||
| queryConn, isQueryContext := conn.(driver.QueryerContext) | ||
| if !isQueryContext { | ||
| return "", fmt.Errorf("get db version error for unexecpt driver conn") |
pkg/datasource/sql/util/convert.go
Outdated
| size := len(parts) | ||
| maxVersionDot := 3 | ||
| if size > maxVersionDot+1 { | ||
| return 0, fmt.Errorf("incompatible version format: %s" + version) |
There was a problem hiding this comment.
fmt.Errorf("incompatible version format: %s" , version) 这里是不是应该是这个，+改为，
106umao
approved these changes
Mar 13, 2023
luky116
reviewed
Mar 15, 2023
| } | ||
|
|
||
| type XAConfig struct { | ||
| xaConnConf XAConnConf |
There was a problem hiding this comment.
有的，他只有一个字段。branchExecutionTimeoutXA
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #467 +/- ##
==========================================
- Coverage 38.38% 36.83% -1.56%
==========================================
Files 155 159 +4
Lines 10319 11020 +701
==========================================
+ Hits 3961 4059 +98
- Misses 6032 6615 +583
- Partials 326 346 +20
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wang1309
approved these changes
Mar 16, 2023
luky116
approved these changes
Mar 17, 2023
georgehao
added a commit
to georgehao/seata-go
that referenced
this pull request
May 7, 2023
* feat: add xa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: