Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chores: optimizing the error returns in the seataserver controller #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chores: optimizing the error returns in the seataserver controller #23

wants to merge 1 commit into from

Conversation

Iceber
Copy link
Contributor

@Iceber Iceber commented May 30, 2024

Minimizing the use of elseif / else will make the code clearer

@Iceber Iceber changed the title chroes: optimizing the error returns in the seataserver controller chores: optimizing the error returns in the seataserver controller May 30, 2024
slievrly
slievrly reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the conflict needs to be dealt with.

@Iceber Iceber requested a review from slievrly June 13, 2024 05:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly Awaiting requested review from slievrly

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iceber @slievrly