Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxGlobalSessionSize not MaxBranchSessionSize #6189

Closed
1 task
funky-eyes opened this issue Dec 21, 2023 · 3 comments
Closed
1 task

MaxGlobalSessionSize not MaxBranchSessionSize #6189

funky-eyes opened this issue Dec 21, 2023 · 3 comments
Labels
task: help-wanted Extra attention is needed type: optimize

Comments

@funky-eyes
Copy link
Contributor

funky-eyes commented Dec 21, 2023

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

1.MaxGlobalSessionSize和MaxBranchSessionSize的含义不清,我建议启用新的配置项,比如MaxBranchSessionBytes来取代
2.在代码上,明明是globalsession过大,却提示成了branchsession,这非常不对
基于以上几个问题,我希望社区可以提出一个良好的解决方案来优化此问题

1 The meaning of MaxGlobalSessionSize and MaxBranchSessionSize is unclear, I suggest enabling new configuration items, such as MaxBranchSessionBytes to replace
2 In the code, obviously the globalsession is too large, but it prompts that it becomes a branchsession, which is very wrong
Based on the above problems, I hope the community can come up with a good solution to optimize this problem
image

Ⅱ. Describe what happened

If there is an exception, please attach the exception trace:

Just paste your stack trace here!

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

  1. xxx
  2. xxx
  3. xxx

Minimal yet complete reproducer code (or URL to code):

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • JDK version(e.g. java -version):
  • Seata client/server version:
  • Database version:
  • OS(e.g. uname -a):
  • Others:
@funky-eyes funky-eyes added task: help-wanted Extra attention is needed type: optimize labels Dec 21, 2023
@funky-eyes funky-eyes changed the title MaxGlobalSessionSize and MaxBranchSessionSize should be stopped beforehand, not afterwards MaxGlobalSessionSize not MaxBranchSessionSize Dec 23, 2023
@laywin
Copy link
Contributor

laywin commented Dec 26, 2023

我看了一下这个命名,存在一些其他xx_SIZE,我认为这一个默认的约定,如果没有特殊指明,就是bytes,你的建议了?

I took a look at this naming, and there are some other xx_SIZE. I think this default convention, if not specified, is bytes. Do you have any suggestions?

@Jamesmahaitao
Copy link

我觉得size这个变量名称没必要改,因为

  1. 具有通用性,后续如果变了单位,难道要再次兼容吗?
  2. 项目中很多地方都用这个size,要改的话需要全部改,风险比较大
    建议在注释中写清楚这个单位是什么,然后改一下log打印的内容就可以了

@funky-eyes
Copy link
Contributor Author

我觉得size这个变量名称没必要改,因为

  1. 具有通用性,后续如果变了单位,难道要再次兼容吗?
  2. 项目中很多地方都用这个size,要改的话需要全部改,风险比较大
    建议在注释中写清楚这个单位是什么,然后改一下log打印的内容就可以了

你说的也是一种方式,先把错误的提示改了,再从日志中增加单位提示
What you said is also a way. Change the wrong prompt first, and then add the unit prompt from the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task: help-wanted Extra attention is needed type: optimize
Projects
None yet
Development

No branches or pull requests

3 participants