Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:modify error message which is global session size more than config. #6259

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Jan 13, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#6189

Ⅱ. Does this pull request fix one issue?

#6189

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ea9c54f) 50.96% compared to head (d3f93cc) 51.01%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6259      +/-   ##
============================================
+ Coverage     50.96%   51.01%   +0.04%     
- Complexity     5089     5091       +2     
============================================
  Files           917      917              
  Lines         32022    32022              
  Branches       3862     3862              
============================================
+ Hits          16320    16335      +15     
+ Misses        14129    14108      -21     
- Partials       1573     1579       +6     
Files Coverage Δ
...in/java/io/seata/server/session/GlobalSession.java 72.22% <0.00%> (ø)

... and 5 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 2101a95 into apache:2.x Jan 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants