Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a missing placeholder in INSERT_UNDO_LOG_SQL #1165

Merged
merged 1 commit into from
Jun 4, 2019
Merged

add a missing placeholder in INSERT_UNDO_LOG_SQL #1165

merged 1 commit into from
Jun 4, 2019

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Jun 4, 2019

Ⅰ. Describe what this PR did

only add a missing placeholder in INSERT_UNDO_LOG_SQL

Ⅱ. Does this pull request fix one issue?

fixes #1164

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #1165 into develop will increase coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1165      +/-   ##
=============================================
+ Coverage      41.92%   41.93%   +0.01%     
  Complexity      1385     1385              
=============================================
  Files            246      246              
  Lines          10247    10248       +1     
  Branches        1343     1343              
=============================================
+ Hits            4296     4298       +2     
- Misses          5386     5387       +1     
+ Partials         565      563       -2
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/undo/UndoLogManager.java 20.93% <14.28%> (-0.13%) 8 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 46.34% <0%> (+0.69%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f40777...0dcb4a6. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 5afa229 into apache:develop Jun 4, 2019
@leizhiyuan leizhiyuan deleted the fix_bug_of_undo_log_manager branch June 4, 2019 11:59
@leizhiyuan leizhiyuan added this to the 0.7.0 milestone Jul 10, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing placeholder of UndoLogManager
4 participants