fix #195 add context unit test #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #488 +/- ##
============================================
+ Coverage 28.01% 28.32% +0.3%
- Complexity 646 659 +13
============================================
Files 193 193
Lines 7456 7456
Branches 910 910
============================================
+ Hits 2089 2112 +23
+ Misses 5149 5123 -26
- Partials 218 221 +3
Continue to review full report at Codecov.
|
slievrly
reviewed
Mar 4, 2019
|
|
||
| @Test | ||
| public void testAssertNotInGlobalTransaction() { | ||
| RootContext.assertNotInGlobalTransaction(); |
There was a problem hiding this comment.
this case without exception，the next one with exception
| public void testAssertNotInGlobalTransactionWithException() { | ||
| RootContext.assertNotInGlobalTransaction(); | ||
| RootContext.bind(DEFAULT_XID); | ||
| RootContext.assertNotInGlobalTransaction(); |
There was a problem hiding this comment.
when the UT have finished or all UT for this class have finished, should clear RootContext。It may affect other UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add unit test
Ⅱ. Does this pull request fix one issue?
fix #195
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews