Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support http put #5070

Merged
merged 5 commits into from
Feb 21, 2023
Merged

feature: support http put #5070

merged 5 commits into from
Feb 21, 2023

Conversation

zsp419
Copy link
Contributor

@zsp419 zsp419 commented Nov 9, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

使AbstractHttpExecutor类支持PUT方式的请求

Ⅱ. Does this pull request fix one issue?

fixes #5067

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #5070 (42174af) into 2.x (bf99018) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 42174af differs from pull request most recent head 4766e00. Consider uploading reports for the commit 4766e00 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5070      +/-   ##
============================================
- Coverage     48.95%   48.95%   -0.01%     
  Complexity     4168     4168              
============================================
  Files           741      741              
  Lines         26521    26531      +10     
  Branches       3294     3295       +1     
============================================
+ Hits          12984    12987       +3     
- Misses        12129    12140      +11     
+ Partials       1408     1404       -4     
Impacted Files Coverage Δ
...o/seata/integration/http/AbstractHttpExecutor.java 55.55% <50.00%> (-8.60%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 47.95% <0.00%> (-0.82%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 78.68% <0.00%> (ø)
...rage/redis/store/RedisTransactionStoreManager.java 75.19% <0.00%> (+0.52%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the base branch from develop to 2.x February 21, 2023 10:23
@slievrly
Copy link
Member

@zsp419 thanks for your contribution, can you submit a same pr to branch 2.x?

@slievrly
Copy link
Member

Currently can only merge into develop due to code conflicts.

@slievrly slievrly changed the base branch from 2.x to develop February 21, 2023 10:26
@slievrly slievrly added this to the 1.7.0 milestone Feb 21, 2023
@slievrly slievrly merged commit e0a02fb into apache:develop Feb 21, 2023
@zsp419
Copy link
Contributor Author

zsp419 commented Feb 21, 2023

ok,I'll take care of it soon

@slievrly
Copy link
Member

ok,I'll take care of it soon

thank you.

@zsp419
Copy link
Contributor Author

zsp419 commented Feb 21, 2023

ok,I'll take care of it soon

thank you.

#5377 已重新提交pr

l81893521 pushed a commit to l81893521/seata that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http工具类AbstractHttpExecutor中,缺少PUT方式的方法
6 participants