optimize: publish images based on java 8, 8-slim, 17, 17-slim
#5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangliang181230
changed the title
wangliang181230
changed the title
setup-java to 3.9.0, and simplify the action script
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5168 +/- ##
=============================================
+ Coverage 48.69% 48.77% +0.07%
+ Complexity 4187 4176 -11
=============================================
Files 744 743 -1
Lines 26687 26626 -61
Branches 3332 3333 +1
=============================================
- Hits 12995 12986 -9
+ Misses 12295 12239 -56
- Partials 1397 1401 +4
|
# Conflicts: # .github/workflows/publishes.yml
wangliang181230
changed the title
setup-java to 3.9.0, and simplify the action scriptDocker Hub based on java8, java8-slim, java17, java17-slim
wangliang181230
changed the title
Docker Hub based on java8, java8-slim, java17, java17-slimDocker Hub based on java8, java8-slim, java17, java17-slim, and upgrade setup-java to 3.9.0
wangliang181230
changed the title
Docker Hub based on java8, java8-slim, java17, java17-slim, and upgrade setup-java to 3.9.0Docker Hub based on java 8, 8-slim, 17, 17-slim, and upgrade setup-java to 3.9.0
# Conflicts: # .github/workflows/build.yml # .github/workflows/publishes.yml
wangliang181230
commented
Feb 9, 2023
| <version>${junit-jupiter.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
避免项目下载低版本的junit5的依赖。
slievrly
reviewed
Feb 21, 2023
slievrly
reviewed
Feb 21, 2023
slievrly
reviewed
Feb 21, 2023
slievrly
reviewed
Feb 21, 2023
.github/workflows/build.yml
Outdated
| bash -exc 'apt-get update -y && \ | ||
| apt-get install maven -y && \ | ||
| mvn -Prelease-seata -Dmaven.test.skip=true clean install -U' | ||
| ./mvnw -T 4C clean test-compile -Dcheckstyle.skip=false -Dlicense.skip=false -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn; |
There was a problem hiding this comment.
just compile src undersrc/test ?
There was a problem hiding this comment.
No, it contains src/main
slievrly
reviewed
Feb 21, 2023
.github/workflows/build.yml
Outdated
| strategy: | ||
| # job 1: Compile based on java11, and checkstyle. | ||
| compile: | ||
| name: "compile" |
There was a problem hiding this comment.
I think the hierarchy is clearer and simpler without splitting(compile and build )
There was a problem hiding this comment.
done, remove the compile job.
slievrly
changed the title
Docker Hub based on java 8, 8-slim, 17, 17-slim, and upgrade setup-java to 3.9.08, 8-slim, 17, 17-slim
wangliang181230
added a commit
to wangliang181230/seata
that referenced
this pull request
Mar 8, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize: Publish images to
Docker Hubbased on java8,8-slim,17,17-slim, and upgradesetup-javato3.9.0, and simplify the action script.java8,java8-slim,java17,java17-slim发布docker镜像到Docker Hub上；setup-java至3.9.0，并简化发布脚本。另外，调整
build.yml的脚本：compile的job，编译java11，同时运行checkstyle.build的job，测试java8和17。参照我fork仓库里的action记录，执行成功了。
https://github.com/wangliang181230/seata/actions/runs/3779671964
我自己的测试仓库里，上传成功的镜像记录截图。
https://hub.docker.com/r/easyj/seata-server/tags