Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test-1] add test for FrameworkException #523

Merged
merged 2 commits into from
Mar 6, 2019
Merged

[Test-1] add test for FrameworkException #523

merged 2 commits into from
Mar 6, 2019

Conversation

xiaoheiAh
Copy link
Contributor

Ⅰ. Describe what this PR did

add test for FrameworkException

Ⅱ. Does this pull request fix one issue?

fix #195

Ⅲ. Why don't you add test cases (unit test/integration test)?

already add

Ⅳ. Describe how to verify it

run ut first

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misoperation

@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #523 into develop will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #523      +/-   ##
=============================================
+ Coverage      31.81%   32.38%   +0.57%     
- Complexity       735      749      +14     
=============================================
  Files            195      195              
  Lines           7595     7595              
  Branches         911      911              
=============================================
+ Hits            2416     2460      +44     
+ Misses          4926     4880      -46     
- Partials         253      255       +2
Impacted Files Coverage Δ Complexity Δ
...ba/fescar/common/exception/FrameworkException.java 77.77% <0%> (+77.77%) 12% <0%> (+12%) ⬆️
...ba/fescar/common/exception/FrameworkErrorCode.java 95.83% <0%> (+95.83%) 2% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec825e6...2a7a4bb. Read the comment docs.

@slievrly slievrly merged commit 50cdf84 into apache:develop Mar 6, 2019
@wangliang181230 wangliang181230 added this to the 0.3.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test case should be added to enhance the test coverage
4 participants