Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the incomplete dependency of distribution module #5261

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

HEIBAIJIE
Copy link
Contributor

@HEIBAIJIE HEIBAIJIE commented Jan 20, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add apm-seata-skywalking-plugin to the dependency of distribution module,so it can be built before distribution.
The reason is, we have to build ext/apm-skywalking before we move this folder to distribution folder.

Ⅱ. Does this pull request fix one issue?

fix #5245

Ⅲ. Why don't you add test cases (unit test/integration test)?

There is no code change.

Ⅳ. Describe how to verify it

mvn -Prelease-seata -Dmaven.test.skip=true clean install -U
We can see apm-seata-skywalking-plugin build before seata-distribution.
And we can see /ext folder under distribution/target/seata-server-1.6.1/seata
image
image

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Merging #5261 (31b8468) into develop (6a7e1bb) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5261      +/-   ##
=============================================
+ Coverage      48.85%   48.89%   +0.04%     
- Complexity      4164     4168       +4     
=============================================
  Files            743      743              
  Lines          26538    26538              
  Branches        3301     3301              
=============================================
+ Hits           12964    12977      +13     
+ Misses         12165    12153      -12     
+ Partials        1409     1408       -1     
Impacted Files Coverage Δ
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...in/java/io/seata/server/session/BranchSession.java 79.28% <0.00%> (+0.71%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 80.15% <0.00%> (+1.14%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 60.45% <0.00%> (+1.28%) ⬆️
...o/seata/server/session/AbstractSessionManager.java 64.17% <0.00%> (+2.98%) ⬆️
.../java/io/seata/server/coordinator/DefaultCore.java 54.11% <0.00%> (+5.88%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit fda8060 into apache:develop Jan 29, 2023
@wangliang181230 wangliang181230 added this to the 1.7.0 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants