bugfix: parallel request handle throw IndexOutOfBoundsException #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: bug
funky-eyes
commented
Feb 2, 2023
| @@ -179,26 +178,26 @@ private void onRequestMessage(ChannelHandlerContext ctx, RpcMessage rpcMessage) | |||
| } | |||
| } | |||
| } else { | |||
| List<AbstractResultMessage> results = new CopyOnWriteArrayList<>(); | |||
| List<CompletableFuture<Void>> completableFutures = null; | |||
| List<AbstractResultMessage> results = new ArrayList<>(); | |||
There was a problem hiding this comment.
不在多线程中add，不存在线程安全问题，改为ArrayList
| List<AbstractResultMessage> results = new CopyOnWriteArrayList<>(); | ||
| List<CompletableFuture<Void>> completableFutures = null; | ||
| List<AbstractResultMessage> results = new ArrayList<>(); | ||
| List<CompletableFuture<AbstractResultMessage>> completableFutures = null; |
There was a problem hiding this comment.
每个future的返回值都为AbstractResultMessage
| results.add(finalI, handleRequestsByMergedWarpMessage( | ||
| ((MergedWarpMessage)message).msgs.get(finalI), rpcContext)); | ||
| })); | ||
| completableFutures.add(CompletableFuture.supplyAsync(() -> handleRequestsByMergedWarpMessage( |
There was a problem hiding this comment.
有序的将每个执行request处理的future放入completableFutures
| } else { | ||
| results.add(i, | ||
| handleRequestsByMergedWarpMessage(((MergedWarpMessage)message).msgs.get(i), rpcContext)); | ||
| } | ||
| } | ||
| if (CollectionUtils.isNotEmpty(completableFutures)) { | ||
| try { | ||
| CompletableFuture.allOf(completableFutures.toArray(new CompletableFuture[0])).get(); | ||
| for (CompletableFuture<AbstractResultMessage> completableFuture : completableFutures) { | ||
| results.add(completableFuture.get()); |
There was a problem hiding this comment.
按顺序读取再加回去，completableFutures的数量等于msgs，顺序也一致
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5280
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews