Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: unified project version #5372

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Feb 21, 2023

optimize: Unified version.
优化:统一维护版本号到<revision>Version.java 文件中不需要再修改版本号了。

@wangliang181230 wangliang181230 changed the base branch from 2.x to develop February 21, 2023 09:52
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #5372 (df83b2e) into develop (85b2f34) will increase coverage by 0.09%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5372      +/-   ##
=============================================
+ Coverage      48.52%   48.61%   +0.09%     
- Complexity      4171     4179       +8     
=============================================
  Files            743      743              
  Lines          26644    26646       +2     
  Branches        3328     3328              
=============================================
+ Hits           12930    12955      +25     
+ Misses         12318    12296      -22     
+ Partials        1396     1395       -1     
Impacted Files Coverage Δ
.../src/main/java/io/seata/core/protocol/Version.java 47.61% <80.00%> (+40.11%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...erver/storage/file/session/FileSessionManager.java 53.50% <0.00%> (-0.64%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 46.77% <0.00%> (-0.41%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 75.71% <0.00%> (+0.78%) ⬆️
.../java/io/seata/spring/util/TCCBeanParserUtils.java 32.25% <0.00%> (+1.61%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️
...ta/core/protocol/IncompatibleVersionException.java 100.00% <0.00%> (+100.00%) ⬆️

@slievrly
Copy link
Member

check valid.
image

@slievrly slievrly added this to the 1.7.0 milestone Feb 22, 2023
@slievrly slievrly changed the title optimize: Unified version optimize: unified project version Feb 22, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 00ca98c into apache:develop Feb 22, 2023
@wangliang181230 wangliang181230 deleted the unified-version branch February 22, 2023 08:06
wangliang181230 added a commit to wangliang181230/seata that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants