-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix : check if table meta cache should be refreshed in AT mode #5395
Conversation
…ache#4734) (cherry picked from commit 28b3413)
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5395 +/- ##
============================================
- Coverage 48.81% 48.77% -0.05%
+ Complexity 4341 4338 -3
============================================
Files 775 776 +1
Lines 27391 27432 +41
Branches 3406 3410 +4
============================================
+ Hits 13372 13380 +8
- Misses 12629 12657 +28
- Partials 1390 1395 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How to stop the refresh thread after the dataSource is closed?
- How to close the refresh thread after dataSource overwriting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bughue Please improve it in the next pr.
@@ -40,7 +40,7 @@ Seata 是一款开源的分布式事务解决方案,提供高性能和简单 | |||
- [[#5355](https://github.com/seata/seata/pull/5355)] 修复自定义context-path时的问题 | |||
- [[#5362](https://github.com/seata/seata/pull/5362)] 修复当TC端回滚返回RollbackFailed时,自定义FailureHandler的方法未执行 | |||
- [[#5372](https://github.com/seata/seata/pull/5372)] 修复客户侧事务提交前超时未执行hook和failureHandler的问题 | |||
|
|||
- [[#4734](https://github.com/seata/seata/pull/4734)] 修复AT模式下新增字段产生的字段找不到 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr code incorrect.
#4734
(cherry picked from commit 28b3413)
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews