Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-os.yml for OS #6081

Merged
merged 61 commits into from
Dec 9, 2023
Merged

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Nov 27, 2023

1、PR

  1. 添加 test-os.yml 用于测试seata在各种操作系统下的运行情况。
    test: add test-os.yml for testing the OS

  2. 调整单测、actions脚本、插件版本,提高CI成功率。
    Adjust unit-test, actions script and plugin versions to improve CI success rate.

  3. 优化部分日志。
    Optimize some logs.

2、测试成功日志(Test success log):

https://github.com/wangliang181230/seata/actions?query=branch%3Atest-os-2.x

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #6081 (bc12d52) into 2.x (bdfed8d) will increase coverage by 0.27%.
The diff coverage is 15.38%.

❗ Current head bc12d52 differs from pull request most recent head 9a1b17c. Consider uploading reports for the commit 9a1b17c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6081      +/-   ##
============================================
+ Coverage     49.08%   49.35%   +0.27%     
- Complexity     4782     4805      +23     
============================================
  Files           913      913              
  Lines         31678    31710      +32     
  Branches       3826     3827       +1     
============================================
+ Hits          15549    15651     +102     
+ Misses        14592    14517      -75     
- Partials       1537     1542       +5     
Files Coverage Δ
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 18.51% <0.00%> (ø)
...ta/discovery/registry/FileRegistryServiceImpl.java 0.00% <0.00%> (ø)
...ta/core/serializer/SerializerSecurityRegistry.java 54.44% <16.21%> (-28.89%) ⬇️

... and 24 files with indirect coverage changes

else
./mvnw -T 4C clean test -P args-for-client-test -Dspring-boot.version=${{ matrix.springboot }} -Dcheckstyle.skip=true -Dlicense.skip=true -Dmaven.git-commit-id.skip=true -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;
fi
./mvnw -T 4C clean install \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need an install phase ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is unnecessary in regular unit testing.
I only want it applied to unit-test of various OSs.
I'll fix it.

哦,这在常规测试中的确是不需要的。
我只想把它用在对各OS的测试中。
我等下修改一下。

branches: [ test*, "*.*.*" ]

jobs:
# job 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, it feels awkward to separate the arm64 testing from the Spring testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I will try to merge test.yml and test-os.yml.

那我尝试把 test.ymltest-os.yml 合并掉。

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants