Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix oracle column alias cannot find #6086

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

cherry-pick #5819 #5785

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #6086 (8f6cc2c) into 2.x (3702ff8) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6086      +/-   ##
============================================
- Coverage     49.55%   49.51%   -0.04%     
+ Complexity     4765     4762       -3     
============================================
  Files           909      909              
  Lines         31390    31390              
  Branches       3782     3782              
============================================
- Hits          15554    15542      -12     
- Misses        14301    14309       +8     
- Partials       1535     1539       +4     

see 6 files with indirect coverage changes

Signed-off-by: slievrly <[email protected]>
Signed-off-by: slievrly <[email protected]>
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Nov 27, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: AT AT transaction mode module/rm-datasource rm-datasource module labels Nov 27, 2023
@funky-eyes funky-eyes merged commit 2122c6d into apache:2.x Nov 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants