Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: modify the semantics of RaftServerFactory and remove unnecessary singleton #6089

Merged
merged 12 commits into from
Nov 29, 2023

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6083

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes changed the title optimize: Modify the semantics of RaftServerFactory and remove unnecessary singleton optimize: modify the semantics of RaftServerFactory and remove unnecessary singleton Nov 27, 2023
@funky-eyes funky-eyes added this to the 2.1.0 milestone Nov 27, 2023
@funky-eyes funky-eyes closed this Nov 28, 2023
@funky-eyes funky-eyes reopened this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #6089 (c8136dd) into 2.x (9fef2db) will decrease coverage by 0.05%.
The diff coverage is 66.07%.

❗ Current head c8136dd differs from pull request most recent head 186a7f6. Consider uploading reports for the commit 186a7f6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6089      +/-   ##
============================================
- Coverage     49.53%   49.49%   -0.05%     
+ Complexity     4783     4758      -25     
============================================
  Files           909      909              
  Lines         31418    31388      -30     
  Branches       3778     3782       +4     
============================================
- Hits          15563    15534      -29     
+ Misses        14316    14313       -3     
- Partials       1539     1541       +2     
Files Coverage Δ
...o/seata/server/cluster/raft/util/RaftTaskUtil.java 28.00% <100.00%> (ø)
...in/java/io/seata/server/session/SessionHolder.java 52.81% <100.00%> (ø)
...io/seata/server/cluster/raft/RaftStateMachine.java 61.11% <0.00%> (-1.39%) ⬇️
...erver/storage/raft/lock/RaftDistributedLocker.java 20.00% <0.00%> (ø)
.../snapshot/metadata/LeaderMetadataSnapshotFile.java 16.66% <0.00%> (-0.58%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 72.96% <0.00%> (ø)
.../io/seata/server/controller/ClusterController.java 8.69% <0.00%> (ø)
...o/seata/server/cluster/raft/RaftServerManager.java 85.71% <78.04%> (ø)

... and 7 files with indirect coverage changes

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seata 2.0.0 TCC事务发起异常
2 participants