Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove lgtm.com badge #6116

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Dec 8, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

This PR will remove the lgtm.com stuff as it's no longer available.

Ⅱ. Does this pull request fix one issue?

fixes #6115

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #6116 (ee02757) into 2.x (9e5abc2) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6116      +/-   ##
============================================
- Coverage     49.45%   49.40%   -0.05%     
+ Complexity     4811     4808       -3     
============================================
  Files           913      913              
  Lines         31678    31678              
  Branches       3826     3826              
============================================
- Hits          15665    15650      -15     
- Misses        14474    14486      +12     
- Partials       1539     1542       +3     

see 5 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 9, 2023
@leizhiyuan leizhiyuan self-requested a review December 9, 2023 11:55
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title remove lgtm.com stuff optimize: remove lgtm.com badge Dec 9, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit bdfed8d into apache:2.x Dec 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The lgtm.com stuff should be removed as it's no longer available
4 participants