Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the branch transaction order error when rolling back #6121

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6120

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan leizhiyuan added this to the 2.1.0 milestone Dec 9, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #6121 (85c61f5) into 2.x (471d413) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6121      +/-   ##
============================================
- Coverage     49.07%   49.04%   -0.03%     
+ Complexity     4779     4777       -2     
============================================
  Files           913      913              
  Lines         31678    31678              
  Branches       3826     3826              
============================================
- Hits          15545    15537       -8     
- Misses        14594    14603       +9     
+ Partials       1539     1538       -1     
Files Coverage Δ
.../java/io/seata/server/coordinator/DefaultCore.java 52.90% <100.00%> (ø)

... and 3 files with indirect coverage changes

@funky-eyes funky-eyes merged commit d1aa1ca into apache:2.x Dec 9, 2023
8 checks passed
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
3 participants