Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unbind xid in TransactionTemplateTest #6125

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Dec 9, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #6125 (4668b73) into 2.x (9e5abc2) will decrease coverage by 0.36%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6125      +/-   ##
============================================
- Coverage     49.45%   49.10%   -0.36%     
+ Complexity     4811     4785      -26     
============================================
  Files           913      913              
  Lines         31678    31678              
  Branches       3826     3826              
============================================
- Hits          15665    15554     -111     
- Misses        14474    14590     +116     
+ Partials       1539     1534       -5     

see 18 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 9, 2023
changes/en-us/2.x.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes changed the title optimize: unbind xid in TransactionTemplateTest test: unbind xid in TransactionTemplateTest Dec 9, 2023
@funky-eyes funky-eyes added TM Relate to seata tm module/tm tm module type: test test case labels Dec 9, 2023
@funky-eyes funky-eyes closed this Dec 9, 2023
@funky-eyes funky-eyes reopened this Dec 9, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 471d413 into apache:2.x Dec 9, 2023
13 checks passed
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/tm tm module TM Relate to seata tm type: test test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants