Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: upgrade nacos client to 1.4.6 #6144

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

upgrade nacos client to 1.4.6

Ⅱ. Does this pull request fix one issue?

fix #6139

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #6144 (061488c) into 2.x (5563492) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6144      +/-   ##
============================================
+ Coverage     48.94%   48.99%   +0.05%     
- Complexity     4775     4777       +2     
============================================
  Files           913      913              
  Lines         31710    31710              
  Branches       3827     3827              
============================================
+ Hits          15521    15537      +16     
+ Misses        14653    14630      -23     
- Partials       1536     1543       +7     

see 18 files with indirect coverage changes

@leizhiyuan leizhiyuan self-requested a review December 13, 2023 07:25
Copy link
Contributor

@leizhiyuan leizhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@funky-eyes funky-eyes merged commit c0d0445 into apache:2.x Dec 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0版本存在 【Nacos 集群Raft反序列化漏洞】望修复
3 participants