security: upgrade kafka-clients to 3.6.1 #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Dec 13, 2023
dependencies/pom.xml
Outdated
| @@ -91,6 +91,7 @@ | |||
| <logback.version>1.2.9</logback.version> | |||
| <logstash-logback-encoder.version>6.5</logstash-logback-encoder.version> | |||
| <kafka-appender.version>0.2.0-RC2</kafka-appender.version> | |||
| <kafka-clients.version>3.5.2</kafka-clients.version> | |||
There was a problem hiding this comment.
Why not use 3.6.1?
Suggested change
| <kafka-clients.version>3.5.2</kafka-clients.version> | |
| <kafka-clients.version>3.6.1</kafka-clients.version> |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6147 +/- ##
============================================
+ Coverage 48.98% 49.00% +0.01%
+ Complexity 4782 4781 -1
============================================
Files 913 913
Lines 31697 31697
Branches 3823 3823
============================================
+ Hits 15528 15532 +4
+ Misses 14632 14628 -4
Partials 1537 1537
|
funky-eyes
reviewed
Dec 15, 2023
changes/zh-cn/2.x.md
Outdated
| @@ -27,6 +27,7 @@ | |||
|
|
|||
| ### security: | |||
| - [[#6069](https://github.com/seata/seata/pull/6069)] 升级Guava依赖版本，修复安全漏洞 | |||
| - [[#6147](https://github.com/seata/seata/pull/6147)] 升级 kafka-clients依赖至3.5.2 | |||
There was a problem hiding this comment.
Suggested change
| - [[#6147](https://github.com/seata/seata/pull/6147)] 升级 kafka-clients依赖至3.5.2 | |
| - [[#6147](https://github.com/seata/seata/pull/6147)] 升级 kafka-clients依赖至3.6.1 |
changes/en-us/2.x.md
Outdated
| @@ -28,6 +28,7 @@ Add changes here for all PR submitted to the 2.x branch. | |||
|
|
|||
| ### security: | |||
| - [[#6069](https://github.com/seata/seata/pull/6069)] Upgrade Guava dependencies to fix security vulnerabilities | |||
| - [[#6147](https://github.com/seata/seata/pull/6147)] upgrade kafka-clients to 3.5.2 | |||
There was a problem hiding this comment.
Suggested change
| - [[#6147](https://github.com/seata/seata/pull/6147)] upgrade kafka-clients to 3.5.2 | |
| - [[#6147](https://github.com/seata/seata/pull/6147)] upgrade kafka-clients to 3.6.1 |
…13_03 # Conflicts: # changes/zh-cn/2.x.md
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
upgrade kafka-clients to 3.5.2
Ⅱ. Does this pull request fix one issue?
fixes #6092
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews